Bug in new GetPoint
Forum » General / Bug Reports » Bug in new GetPoint
Started by: Marco Altomonte (guest)
On: 1257769292|%e %b %Y, %H:%M %Z|agohover
Number of posts: 7
rss icon RSS: New posts
Summary:
The new patched GetPoint is bugged.
Bug in new GetPoint
Marco Altomonte (guest) 1257769292|%e %b %Y, %H:%M %Z|agohover

GetPoint function in JigLibX\Geometry\Line.cs is:

// BEN-OPTIMISATION: New method, ref point.
public void GetPoint(ref Vector3 point, float t)
{
point.X = t * Delta.X + Origin.X;
point.Y = t * Delta.X + Origin.X;
point.Z = t * Delta.X + Origin.X;
}

but it should be:

// BEN-OPTIMISATION: New method, ref point.
public void GetPoint(ref Vector3 point, float t)
{
point.X = t * Delta.X + Origin.X;
point.Y = t * Delta.Y + Origin.Y;
point.Z = t * Delta.Z + Origin.Z;
}

unfold Bug in new GetPoint by Marco Altomonte (guest), 1257769292|%e %b %Y, %H:%M %Z|agohover
Re: Bug in new GetPoint
PGlynnPGlynn 1257791157|%e %b %Y, %H:%M %Z|agohover

wow good find!

last edited on 1257791169|%e %b %Y, %H:%M %Z|agohover by PGlynn + show more
unfold Re: Bug in new GetPoint by PGlynnPGlynn, 1257791157|%e %b %Y, %H:%M %Z|agohover
Re: Bug in new GetPoint
DevanDangerDevanDanger 1257791563|%e %b %Y, %H:%M %Z|agohover

When copy-and-paste programming goes bad :)

unfold Re: Bug in new GetPoint by DevanDangerDevanDanger, 1257791563|%e %b %Y, %H:%M %Z|agohover
Re: Bug in new GetPoint
Benjamin DobellBenjamin Dobell 1257815598|%e %b %Y, %H:%M %Z|agohover

My bad! Thanks for finding that. Definitely a case of bad copy and paste! I'll take a look later today to make sure it's the only such issue.

If you haven't already submit a patch so the repository gets updated.

unfold Re: Bug in new GetPoint by Benjamin DobellBenjamin Dobell, 1257815598|%e %b %Y, %H:%M %Z|agohover
Re: Bug in new GetPoint
Marco Altomonte (guest) 1257842159|%e %b %Y, %H:%M %Z|agohover

Sorry, no patch updated (no time now!)

unfold Re: Bug in new GetPoint by Marco Altomonte (guest), 1257842159|%e %b %Y, %H:%M %Z|agohover
Re: Bug in new GetPoint
Benjamin DobellBenjamin Dobell 1257859360|%e %b %Y, %H:%M %Z|agohover

I've submitted a patch with the correct method. I also did a quick check for similar errors but I didn't find any so hopefully everything is okay.

unfold Re: Bug in new GetPoint by Benjamin DobellBenjamin Dobell, 1257859360|%e %b %Y, %H:%M %Z|agohover
Re: Bug in new GetPoint
noone88noone88 1257868077|%e %b %Y, %H:%M %Z|agohover

uploaded.

unfold Re: Bug in new GetPoint by noone88noone88, 1257868077|%e %b %Y, %H:%M %Z|agohover
New post
Unless otherwise stated, the content of this page is licensed under Creative Commons Attribution-ShareAlike 3.0 License